Skip to content

refactor: Upgrade GraphQL dependencies#7970

Merged
mtrezza merged 5 commits intoparse-community:alphafrom
Moumouls:moumouls/update-gql-dep
Jun 10, 2022
Merged

refactor: Upgrade GraphQL dependencies#7970
mtrezza merged 5 commits intoparse-community:alphafrom
Moumouls:moumouls/update-gql-dep

Conversation

@Moumouls
Copy link
Member

@Moumouls Moumouls commented May 4, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

Update graphql deps

Related issue: #7916
Closes #7916

Approach

Update all packages to latest version

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 4, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@Moumouls Moumouls force-pushed the moumouls/update-gql-dep branch from 83e3d9d to 15c5631 Compare May 4, 2022 17:45
@Moumouls
Copy link
Member Author

Moumouls commented May 4, 2022 •
edited
Loading

I'm not in favor of merging this PR currently since it introduces a possible breaking change with the async apply graphql server.

This PR should be merged after the switch to Yoga: #7967

@Moumouls Moumouls requested review from davimacedo, dblythy and mtrezza May 4, 2022 17:47
@codecov
Copy link

codecov bot commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #7970 (964edf7) into alpha (2d5221e) will decrease coverage by 0.32%.
The diff coverage is 93.33%.

❗ Current head 964edf7 differs from pull request most recent head 34a0798. Consider uploading reports for the commit 34a0798 to get more accurate results

@@            Coverage Diff             @@
##            alpha    #7970      +/-   ##
==========================================
- Coverage   94.11%   93.78%   -0.33%     
==========================================
  Files         182      182              
  Lines       13639    13631       -8     
==========================================
- Hits        12836    12784      -52     
- Misses        803      847      +44
Impacted Files Coverage Δ
src/Controllers/SchemaController.js 97.36% <ø> (ø)
src/GraphQL/loaders/schemaTypes.js 100.00% <ø> (ø)
src/GraphQL/loaders/defaultGraphQLTypes.js 97.06% <66.66%> (ø)
src/GraphQL/loaders/schemaDirectives.js 96.00% <95.45%> (+7.11%) ⬆️
src/GraphQL/ParseGraphQLSchema.js 97.48% <100.00%> (+0.29%) ⬆️
src/GraphQL/loaders/defaultRelaySchema.js 94.73% <100.00%> (ø)
src/Adapters/Cache/RedisCacheAdapter.js 12.28% <0.00%> (-75.44%) ⬇️
src/RestWrite.js 94.10% <0.00%> (-0.31%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.94% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc2843...34a0798. Read the comment docs.

@mtrezza mtrezza removed their request for review May 4, 2022 20:08
This was referenced May 5, 2022
Closed
Closed
Closed
This was referenced May 5, 2022
Closed
Closed
Closed
@Moumouls
Merge branch 'upstream/alpha' into moumouls/update-gql-dep
1ecb0b6 
# Conflicts:
#	package-lock.json
#	package.json
#	src/GraphQL/ParseGraphQLSchema.js
#	src/GraphQL/ParseGraphQLServer.js
@Moumouls Moumouls requested a review from a team May 19, 2022 08:22
@Moumouls
Copy link
Member Author

Moumouls commented May 19, 2022

@mtrezza we are good to go here 🚀

@mtrezza
Copy link
Member

mtrezza commented May 19, 2022 •
edited
Loading

Could you just give this PR a proper title? Remember, it will be used as the changelog entry and that is impacting the DX.

@Moumouls Moumouls changed the title feat: update gql deps refactor: update GraphQL dependencies May 20, 2022
@Moumouls
Copy link
Member Author

Moumouls commented May 20, 2022

done @mtrezza

@mtrezza mtrezza changed the title refactor: update GraphQL dependencies refactor: upgrade GraphQL dependencies May 20, 2022
mtrezza
mtrezza requested changes May 20, 2022
View reviewed changes
@Moumouls Moumouls requested a review from mtrezza June 6, 2022 20:59
@Moumouls
Copy link
Member Author

Moumouls commented Jun 6, 2022

We should be good to go here @mtrezza 🚀

@mtrezza mtrezza removed request for davimacedo and dblythy June 7, 2022 06:58
@mtrezza mtrezza requested a review from a team June 7, 2022 06:58
davimacedo
davimacedo approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me

@Moumouls
Copy link
Member Author

Moumouls commented Jun 9, 2022

@mtrezza could you merge this one ?

@mtrezza
Copy link
Member

mtrezza commented Jun 10, 2022

Rerunning failing CI

@mtrezza mtrezza merged commit 0cd902b into parse-community:alpha Jun 10, 2022
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 11, 2022

🎉 This change has been released in version 5.3.0-alpha.16

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 11, 2022
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 17, 2022

🎉 This change has been released in version 5.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 17, 2022
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 29, 2022

🎉 This change has been released in version 5.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 29, 2022
@mtrezza mtrezza mentioned this pull request Nov 1, 2022
Closed
3 tasks
@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 1, 2022

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: upgrade GraphQL dependencies refactor: Upgrade GraphQL dependencies Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davimacedo davimacedo davimacedo approved these changes

@mtrezza mtrezza Awaiting requested review from mtrezza

+1 more reviewer

@dblythy dblythy dblythy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade GraphQL dependencies

5 participants

@Moumouls @mtrezza @parseplatformorg @davimacedo @dblythy